Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: gpu/command_buffer/service/texture_manager.cc

Issue 1283303002: gpu: FBO must be incomplete if the attached texture is not cube complete. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Depend on https://codereview.chromium.org/1299683002 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: gpu/command_buffer/service/texture_manager.cc
diff --git a/gpu/command_buffer/service/texture_manager.cc b/gpu/command_buffer/service/texture_manager.cc
index 41cf6a3e8c2fb1c61a963ee5d0ac51e73eb09601..5aebb8f643707e8797e954338e197e059224d8b7 100644
--- a/gpu/command_buffer/service/texture_manager.cc
+++ b/gpu/command_buffer/service/texture_manager.cc
@@ -442,10 +442,11 @@ Texture::TextureCompleteness Texture::GetTextureCompleteness() const {
if (needs_mips) {
if (!texture_2d_complete())
return TEXTURE_INCOMPLETE;
- if (target_ == GL_TEXTURE_CUBE_MAP && !cube_complete())
- return TEXTURE_INCOMPLETE;
}
+ if (target_ == GL_TEXTURE_CUBE_MAP && !cube_complete())
+ return TEXTURE_INCOMPLETE;
+
bool is_npot_compatible = !needs_mips &&
wrap_s_ == GL_CLAMP_TO_EDGE &&
wrap_t_ == GL_CLAMP_TO_EDGE;
« no previous file with comments | « gpu/command_buffer/service/texture_manager.h ('k') | gpu/command_buffer/tests/gl_cube_map_texture_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698