gpu: FBO must be incomplete if the attached texture is not cube complete.

gpu/command_buffer/service/framebuffer_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gpu/command_buffer/service/framebuffer_manager.h"
 #include "base/logging.h"
 #include "base/strings/stringprintf.h"
 #include "gpu/command_buffer/common/gles2_cmd_utils.h"
 #include "gpu/command_buffer/service/renderbuffer_manager.h"
 #include "gpu/command_buffer/service/texture_manager.h"
@@ skipping 58 matching lines @@
                   bool cleared) override {
     renderbuffer_manager->SetCleared(renderbuffer_.get(), cleared);
   }
 
   bool IsTexture(TextureRef* /* texture */) const override { return false; }
 
   bool IsRenderbuffer(Renderbuffer* renderbuffer) const override {
     return renderbuffer_.get() == renderbuffer;
   }
 
+  bool IsAttachmentComplete(FeatureInfo* feature_info) const override {
+    return true;
+  }
+
   bool CanRenderTo() const override { return true; }
 
   void DetachFromFramebuffer(Framebuffer* framebuffer) const override {
     // Nothing to do for renderbuffers.
   }
 
   bool ValidForAttachmentType(GLenum attachment_type,
                               uint32 max_color_attachments) override {
     uint32 need = GLES2Util::GetChannelsNeededForAttachmentType(
         attachment_type, max_color_attachments);
@@ skipping 94 matching lines @@
   }
 
   bool IsRenderbuffer(Renderbuffer* /* renderbuffer */) const override {
     return false;
   }
 
   TextureRef* texture() const {
     return texture_ref_.get();
   }
 
+  bool IsAttachmentComplete(FeatureInfo* feature_info) const override {
+    return texture_ref_->texture()->IsTextureComplete(feature_info);
+  }
+
   bool CanRenderTo() const override {
     return texture_ref_->texture()->CanRenderTo();
   }
 
   void DetachFromFramebuffer(Framebuffer* framebuffer) const override {
     texture_ref_->texture()->DetachFromFramebuffer();
     framebuffer->OnTextureRefDetached(texture_ref_.get());
   }
 
   bool ValidForAttachmentType(GLenum attachment_type,
@@ skipping 252 matching lines @@
   if (read_buffer_ == GL_NONE)
     return 0;
   AttachmentMap::const_iterator it = attachments_.find(read_buffer_);
   if (it == attachments_.end()) {
     return 0;
   }
   const Attachment* attachment = it->second.get();
   return attachment->texture_type();
 }
 
-GLenum Framebuffer::IsPossiblyComplete() const {
+GLenum Framebuffer::IsPossiblyComplete(GLenum target,
+                                       FeatureInfo* feature_info) const {
   if (attachments_.empty()) {
     return GL_FRAMEBUFFER_INCOMPLETE_MISSING_ATTACHMENT;
   }
 
   GLsizei width = -1;
   GLsizei height = -1;
   for (AttachmentMap::const_iterator it = attachments_.begin();
        it != attachments_.end(); ++it) {
     GLenum attachment_type = it->first;
     Attachment* attachment = it->second.get();
     if (!attachment->ValidForAttachmentType(attachment_type,
                                             manager_->max_color_attachments_)) {
       return GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT;
     }
     if (width < 0) {
       width = attachment->width();
       height = attachment->height();
       if (width == 0 || height == 0) {
         return GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT;
       }
     } else if (manager_->context_type() != ContextGroup::CONTEXT_TYPE_WEBGL2) {
       // TODO(zmo): revisit this if we create ES3 contexts for clients other
       // than WebGL 2.
       if (attachment->width() != width || attachment->height() != height) {
         return GL_FRAMEBUFFER_INCOMPLETE_DIMENSIONS_EXT;
       }
     }
 
-    if (!attachment->CanRenderTo()) {
+    if (target != GL_READ_FRAMEBUFFER_EXT && !attachment->CanRenderTo()) {
       return GL_FRAMEBUFFER_UNSUPPORTED;
     }
+
+    // See section 4.4.4 of the GLES3 spec.
+    if (!attachment->IsAttachmentComplete(feature_info)) {
+      return GL_FRAMEBUFFER_INCOMPLETE_ATTACHMENT;
+    }
   }
 
   // This does not mean the framebuffer is actually complete. It just means our
   // checks passed.
   return GL_FRAMEBUFFER_COMPLETE;
 }
 
 GLenum Framebuffer::GetStatus(
     TextureManager* texture_manager, GLenum target) const {
   // Check if we have this combo already.
@@ skipping 266 matching lines @@
        ++it) {
     TextureDetachObserver* observer = *it;
     observer->OnTextureRefDetachedFromFramebuffer(texture);
   }
 }
 
 }  // namespace gles2
 }  // namespace gpu