Service Worker: Change last update check location and HTTP cache bypass rule (2/2)

content/browser/service_worker/service_worker_dispatcher_host.cc

Index: content/browser/service_worker/service_worker_dispatcher_host.cc
diff --git a/content/browser/service_worker/service_worker_dispatcher_host.cc b/content/browser/service_worker/service_worker_dispatcher_host.cc
index 0e9f3c97f2bd3bd9ac021b6cb958b4903137f19e..4fc95d86a24bf91d68b3a0db154beef250ecdf29 100644
--- a/content/browser/service_worker/service_worker_dispatcher_host.cc
+++ b/content/browser/service_worker/service_worker_dispatcher_host.cc
@@ -435,10 +435,12 @@ void ServiceWorkerDispatcherHost::OnUpdateServiceWorker(int thread_id,
     return;
   }
 
-  // The spec says, "update() pings the server for an updated version of this
-  // script without consulting caches", so set |force_bypass_cache| to true.
+  // update() does not always bypass the browser cache. It obeys the same rule
+  // as other update attempts that bypasses the browser cache only when
+  // min(Cache-Control's max-age value, 86400) seconds have passed since the
+  // last update.

[nhiroki, 2015/08/24 07:57:51]

Probably this comment should be moved to service_worker_context_core.h and only
mention 86400 seconds (24-hours) update because the Cache-Control header is
actually handled in the lower network layer like a regular request and SW does
not have to take care of it.

For example, "Updates the service worker. If |force_bypass_cache| is true or
86400 seconds (24 hours) have passed since the last update, bypasses the browser
cache."

[jungkees, 2015/08/25 09:36:51]

Agreed. I'll move the suggested comment to service_worker_context_core.h.

   GetContext()->UpdateServiceWorker(
-      registration, true, /* force_bypass_cache */
+      registration, false, /* force_bypass_cache */
       provider_host, base::Bind(&ServiceWorkerDispatcherHost::UpdateComplete,
                                 this, thread_id, provider_id, request_id));
 }