Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Unified Diff: content/browser/service_worker/service_worker_register_job.cc

Issue 1283273002: Service Worker: Change last update check location and HTTP cache bypass rule (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_register_job.cc
diff --git a/content/browser/service_worker/service_worker_register_job.cc b/content/browser/service_worker/service_worker_register_job.cc
index 16a192858271e92bc9532362686253dc9bb308fb..cfa96728ad7554a8eee92e3f8199c834feb3f868 100644
--- a/content/browser/service_worker/service_worker_register_job.cc
+++ b/content/browser/service_worker/service_worker_register_job.cc
@@ -347,8 +347,7 @@ void ServiceWorkerRegisterJob::OnStartWorkerFinished(
// Only bump the last check time when we've bypassed the browser cache.
base::TimeDelta time_since_last_check =
base::Time::Now() - registration()->last_update_check();
- if (time_since_last_check > base::TimeDelta::FromHours(
- kServiceWorkerScriptMaxCacheAgeInHours) ||
+ if (time_since_last_check > new_version()->max_age() ||
nhiroki 2015/08/19 06:59:01 We could use EmbeddedWorkerInstance::network_acces
jungkees 2015/08/20 01:52:56 I got it. Thanks for the point.
new_version()->force_bypass_cache_for_scripts()) {
registration()->set_last_update_check(base::Time::Now());
context_->storage()->UpdateLastUpdateCheckTime(registration());

Powered by Google App Engine
This is Rietveld 408576698