Service Worker: Change last update check location and HTTP cache bypass rule (2/2)

content/browser/service_worker/service_worker_context_request_handler.cc

Index: content/browser/service_worker/service_worker_context_request_handler.cc
diff --git a/content/browser/service_worker/service_worker_context_request_handler.cc b/content/browser/service_worker/service_worker_context_request_handler.cc
index 8d518857c79106c584fbfa91df23c5d5b82cea8d..206bace9f71e605e541896a9a299adacaf4f03dd 100644
--- a/content/browser/service_worker/service_worker_context_request_handler.cc
+++ b/content/browser/service_worker/service_worker_context_request_handler.cc
@@ -64,16 +64,14 @@ net::URLRequestJob* ServiceWorkerContextRequestHandler::MaybeCreateJob(
     if (response_id == kInvalidServiceWorkerResponseId)
       return NULL;
 
-    // Bypass the browser cache for initial installs and update
-    // checks after 24 hours have passed.
+    // Bypass the browser cache for initial installs and update checks after
+    // min(Cache-Control's max-age value, 86400) seconds have passed.
     int extra_load_flags = 0;
     base::TimeDelta time_since_last_check =
         base::Time::Now() - registration->last_update_check();
-    if (time_since_last_check > base::TimeDelta::FromHours(
-                                    kServiceWorkerScriptMaxCacheAgeInHours) ||
-        version_->force_bypass_cache_for_scripts()) {
+    if (time_since_last_check > version_->max_age() ||

[nhiroki, 2015/08/19 06:59:01]

The original code (time_since_last_check > FromHours(24)) could work for the
latest spec because the max-age is recorded in the HTTP Cache and a network
request can bypass the cache regardless of the bypass flag when the max-age
passed.

[jungkees, 2015/08/20 01:52:56]

Agreed on your point. Having double-checked the logic, the original code should
have been attained the same result.

So, depending on the need/decision of the service worker's max age concept for
scheduled updates, let me apply a relevant code for this part.

+        version_->force_bypass_cache_for_scripts())
       extra_load_flags = net::LOAD_BYPASS_CACHE;
-    }
 
     ServiceWorkerVersion* stored_version = registration->waiting_version()
                                                ? registration->waiting_version()