parserInsertBefore: Bail out if the parent no longer contains the child.

parserInsertBefore: Bail out if the parent no longer contains the child.

nextChild may be removed from the DOM tree during the
|parserRemoveChild(*newChild)| call which triggers unload events of newChild's 
descendant iframes. In order to maintain the integrity of the DOM tree, the
insertion of newChild must be aborted in this case.

This patch adds a return statement that rectifies the behavior in this
edge case.

BUG=519558
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200690

[esprehn, 2015-08-12 19:42:18]

esprehn@chromium.org changed reviewers:
+ esprehn@chromium.org

[esprehn, 2015-08-12 19:42:19]

lgtm w/ nits fixed. Thanks!

https://codereview.chromium.org/1283263002/diff/1/LayoutTests/fast/parser/scr...
File LayoutTests/fast/parser/scriptexec-during-parserInsertBefore.html (right):

https://codereview.chromium.org/1283263002/diff/1/LayoutTests/fast/parser/scr...
LayoutTests/fast/parser/scriptexec-during-parserInsertBefore.html:5: /**
single star

https://codereview.chromium.org/1283263002/diff/1/LayoutTests/fast/parser/scr...
LayoutTests/fast/parser/scriptexec-during-parserInsertBefore.html:15: **/
ditto

https://codereview.chromium.org/1283263002/diff/1/LayoutTests/fast/parser/scr...
LayoutTests/fast/parser/scriptexec-during-parserInsertBefore.html:18: var
firstChild = document.querySelector('i');
double quotes for all these

https://codereview.chromium.org/1283263002/diff/1/LayoutTests/fast/parser/scr...
LayoutTests/fast/parser/scriptexec-during-parserInsertBefore.html:27:
shouldBe("containerNode.childNodes[0]", "firstChild");
.firstChild

[Mariusz Mlynski, 2015-08-12 20:40:18]

Thanks for the review.

[esprehn, 2015-08-12 20:45:22]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2015-08-12 20:45:22]

lgtm

[commit-bot: I haz the power, 2015-08-12 20:45:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283263002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283263002/20001

[commit-bot: I haz the power, 2015-08-12 20:45:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 20:45:40]

The author marius.mlynski@gmail.com has not signed Google Contributor License
Agreement. Please visit https://cla.developers.google.com to sign and manage
CLA.

[Mariusz Mlynski, 2015-08-12 20:48:27]

On 2015/08/12 20:45:40, commit-bot: I haz the power wrote:
> Please visit https://cla.developers.google.com to sign and manage
> CLA.

Done.

[Mariusz Mlynski, 2015-08-12 21:23:15]

It appears that the tests will fail. The corresponding "-expected" file needs to
have the nit correction reflected. Sorry for missing that, I'll provide a fix in
a second.

[Mariusz Mlynski, 2015-08-12 21:41:07]

I've uploaded a corrected version. Luckily, the bot aborted the build
immediately due to the missing license :-)

[Robert Sesek, 2015-08-18 02:06:37]

esphren: Does this still LG?

[Robert Sesek, 2015-08-18 02:11:22]

On 2015/08/18 02:06:37, Robert Sesek wrote:
> esphren: Does this still LG?

(Sorry, esprehn, ^T'd the wrong direction)

[esprehn, 2015-08-18 03:28:03]

The CQ bit was checked by esprehn@chromium.org

[esprehn, 2015-08-18 03:28:03]

lgtm

[commit-bot: I haz the power, 2015-08-18 03:28:21]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283263002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283263002/40001

[commit-bot: I haz the power, 2015-08-18 04:30:59]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200690