snapshot/mac/mach_o_image_segment_reader.cc - Issue 1283243004: ubsan: Don’t call v[0] on empty vectors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: snapshot/mac/mach_o_image_segment_reader.cc

Issue 1283243004: ubsan: Don’t call v[0] on empty vectors (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: snapshot/mac/mach_o_image_segment_reader.cc

diff --git a/snapshot/mac/mach_o_image_segment_reader.cc b/snapshot/mac/mach_o_image_segment_reader.cc

index 5c74d80dd1815ac10a9a6202e003abd1679ec727..9b07e904ea87c6cd47c44bba36d657ae9ae22e6c 100644

--- a/snapshot/mac/mach_o_image_segment_reader.cc

+++ b/snapshot/mac/mach_o_image_segment_reader.cc

@@ -95,7 +95,8 @@ bool MachOImageSegmentReader::Initialize(ProcessReader* process_reader,

}

sections_.resize(segment_command_.nsects);

- if (!process_types::section::ReadArrayInto(

+ if (!sections_.empty() &&

+ !process_types::section::ReadArrayInto(

process_reader,

load_command_address + segment_command_.Size(),

segment_command_.nsects,

« no previous file with comments | « no previous file | snapshot/minidump/process_snapshot_minidump.cc » ('j') | no next file with comments »