Issue 128323002: Hide local host out-of-date warning by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128323002: Hide local host out-of-date warning by default. (Closed)

Created:
6 years, 11 months ago by Jamie

Modified:
6 years, 11 months ago

Reviewers:
weitao

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Hide local host out-of-date warning by default. This avoids it being visible when the user first runs the app if they are able to expand the Me2Me section before the XHR to fetch the host list has completed. Note that they will still see a blank entry in this case, but only if the local host is registered. Since the name of the local host isn't known until the XHR returns, there's no easy solution to that, and given how much a corner case it is, I don't think it's worth fixing. BUG=277168 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243727

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	remoting/webapp/main.html	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamiewalch@chromium.org/128323002/1

6 years, 11 months ago (2014-01-08 17:55:53 UTC) #3

Message was sent while issue was closed.

Change committed as 243727

Expand Messages | Collapse Messages