Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4484)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java

Issue 1283223004: Contextual Search Panel should own ContentViewCore (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Override wrappers instead of native Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
index d448b9b57a1f1334b39a6af1c9c92b1c867c57cd..a11a54e71b9e16ff6fb5abc5d648cf3e98e87c5b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelDelegate.java
@@ -6,6 +6,10 @@ package org.chromium.chrome.browser.compositor.bottombar.contextualsearch;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel.PanelState;
import org.chromium.chrome.browser.compositor.bottombar.contextualsearch.ContextualSearchPanel.StateChangeReason;
+import org.chromium.components.navigation_interception.InterceptNavigationDelegate;
+import org.chromium.components.web_contents_delegate_android.WebContentsDelegateAndroid;
+import org.chromium.content.browser.ContentViewCore;
+import org.chromium.content_public.browser.WebContents;
/**
* The delegate that that interfaces with the {@link ContextualSearchPanel}.
@@ -137,4 +141,48 @@ public interface ContextualSearchPanelDelegate {
* due the panel being promoted to a tab.
*/
boolean shouldAnimatePanelCloseOnPromoteToTab();
+
+ /**
+ * @return The ContentViewCore associated with the panel.
+ */
+ ContentViewCore getContentViewCore();
+
+ /**
+ * Set this panel's ContentViewCore to null.
+ */
+ void resetContentViewCore();
+
+ /**
+ * Destroy the native components of this class.
+ */
+ void destroy();
+
+ /**
+ * Remove the last entry from history provided it is in a given time frame.
+ * @param historyUrl The URL to remove.
+ * @param urlTimeMs The time that the URL was visited.
+ */
+ void removeLastHistoryEntry(String historyUrl, long urlTimeMs);
+
+ /**
+ * Set the WebContents
+ */
+ void setWebContents(ContentViewCore contentView, WebContentsDelegateAndroid delegate);
+
+ /**
+ * Destroy the web contents associated with this object.
+ */
+ void destroyWebContents();
+
+ /**
+ * Reset the native handle to the WebContents.
+ */
+ void releaseWebContents();
+
+ /**
+ * @param delegate InterceptNavigationDelegate to use.
+ * @param webContents The WebContents to associate with the delegate.
+ */
+ void setInterceptNavigationDelegate(
+ InterceptNavigationDelegate delegate, WebContents webContents);
}

Powered by Google App Engine
This is Rietveld 408576698