Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1883)

Issue 12832004: content: Move all listeners of NOTIFICATION_RENDER_VIEW_HOST_CREATED out of content. (Closed)

Created:
7 years, 9 months ago by Paweł Hajdan Jr.
Modified:
7 years, 9 months ago
Reviewers:
sky
CC:
chromium-reviews, marja+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+prer_chromium.org, benjhayden+dwatch_chromium.org, jam, tburkard+watch_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, dominich+watch_chromium.org, scheib+watch_chromium.org, pam+watch_chromium.org, rdsmith+dwatch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, mmenke
Visibility:
Public.

Description

content: Move all listeners of NOTIFICATION_RENDER_VIEW_HOST_CREATED out of content. This is a prerequisite of converting NOTIFICATION_RENDER_VIEW_HOST_CREATED to listeners of RenderViewCreated callback propagated through ContentBrowserClient in chrome. BUG=170921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=188840

Patch Set 1 #

Patch Set 2 : compile fix #

Patch Set 3 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -96 lines) Patch
M chrome/browser/download/download_browsertest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/errorpage_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/app_process_apitest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/redirect_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/managed_mode/managed_mode_resource_throttle_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/performance_monitor/performance_monitor_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/prerender/prerender_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sessions/session_restore_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/fullscreen/fullscreen_controller_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/bookmarks_ui_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.h View 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/test/base/test_tab_strip_model_observer.cc View 1 2 2 chunks +44 lines, -2 lines 0 comments Download
M chrome/test/base/ui_test_utils.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M chrome/test/base/web_ui_browsertest.cc View 3 chunks +57 lines, -1 line 0 comments Download
M content/public/test/test_navigation_observer.h View 1 2 4 chunks +4 lines, -29 lines 0 comments Download
M content/public/test/test_navigation_observer.cc View 4 chunks +0 lines, -47 lines 0 comments Download
M content/test/content_browser_test_utils.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-15 23:49:44 UTC) #1
sky
LGTM
7 years, 9 months ago (2013-03-18 15:55:05 UTC) #2
Paweł Hajdan Jr.
7 years, 9 months ago (2013-03-18 21:50:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r188840.

Powered by Google App Engine
This is Rietveld 408576698