Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1283193008: Fix stack overuse error (Closed)

Created:
5 years, 4 months ago by hal.canary
Modified:
5 years, 4 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : 2015-08-18 (Tuesday) 18:28:43 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M tests/StreamTest.cpp View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
hal.canary
PTAL
5 years, 4 months ago (2015-08-18 22:18:16 UTC) #2
mtklein
lgtm
5 years, 4 months ago (2015-08-18 22:19:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283193008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283193008/1
5 years, 4 months ago (2015-08-18 22:19:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/2816)
5 years, 4 months ago (2015-08-18 22:23:45 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283193008/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283193008/20001
5 years, 4 months ago (2015-08-18 22:29:03 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 13:12:42 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/cb9241baddcca38aa80e43125dc72a99b98bb8ef

Powered by Google App Engine
This is Rietveld 408576698