Issue 1283193003: Restrict chrome.runtime.setUninstallURL to http(s)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1283193003: Restrict chrome.runtime.setUninstallURL to http(s) (Closed)

Created:
5 years, 4 months ago by robwu

Modified:
5 years, 4 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2454

Target Ref:
refs/pending/branch-heads/2454

Project:
chromium

Visibility:
Public.

More Reviews

Description

Restrict chrome.runtime.setUninstallURL to http(s) Disallow URLs other than http(s) in chrome.runtime.setUninstallURL. And allow empty URLs to be set to clear the uninstallation URL. Added an optional callback, to know when setting the URL finished (or failed). BUG=518827 TEST=browser_tests --gtest_filter=ExtensionApiTest.ChromeRuntimeUninstallURL R=kalman@chromium.org Review URL: https://codereview.chromium.org/1282263002 Cr-Commit-Position: refs/heads/master@{#342752} (cherry picked from commit 28fc5b095a1d19eb104a76a08d55292831dce9fa) Committed: https://chromium.googlesource.com/chromium/src/+/d6a6acd6f7155136dc1263a671012eded73955d9

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -7 lines)			Patch
M	chrome/test/data/extensions/api_test/runtime/uninstall_url/test.js	View	1 chunk	+12 lines, -0 lines	0 comments	Download
M	extensions/browser/api/runtime/runtime_api.cc	View	3 chunks	+7 lines, -6 lines	0 comments	Download
M	extensions/common/api/runtime.json	View	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

robwu

5 years, 4 months ago (2015-08-12 13:58:01 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d6a6acd6f7155136dc1263a671012eded73955d9.

Expand Messages | Collapse Messages