Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1283183004: Paranoid temporary check that Chrome's building with SSE2 on all Windows builders. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
egdaniel, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Paranoid temporary check that Chrome's building with SSE2 on all Windows builders. BUG=chromium:475596 Committed: https://skia.googlesource.com/skia/+/e8445307ac33eddcf04457ae21040e47dc9c2a97

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/ports/SkGlobalInitialization_chromium.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mtklein_C
This will add a temporary check, only to Chrome, that Windows implies SSE2 or greater. ...
5 years, 4 months ago (2015-08-12 19:30:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283183004/1
5 years, 4 months ago (2015-08-12 19:31:54 UTC) #4
egdaniel
lgtm with assumption this lands at some quite hour
5 years, 4 months ago (2015-08-12 19:34:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283183004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283183004/1
5 years, 4 months ago (2015-08-14 00:46:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/e8445307ac33eddcf04457ae21040e47dc9c2a97
5 years, 4 months ago (2015-08-14 00:53:33 UTC) #9
mtklein
5 years, 4 months ago (2015-08-14 12:49:10 UTC) #10
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1296593002/ by mtklein@google.com.

The reason for reverting is: Nothing broke.  Experiment is over... SSE2 is
present..

Powered by Google App Engine
This is Rietveld 408576698