Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 1283133004: Add tryserver.infra to Rietveld. (Closed)

Created:
5 years, 4 months ago by Adrian Kuegel
Modified:
5 years, 4 months ago
CC:
chromium-reviews, rmistry+cc_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M appengine/chromium_rietveld/codereview/models_chromium.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Adrian Kuegel
PTAL
5 years, 4 months ago (2015-08-12 13:14:47 UTC) #2
tandrii(chromium)
lgtm
5 years, 4 months ago (2015-08-12 13:18:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1283133004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1283133004/1
5 years, 4 months ago (2015-08-12 13:18:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/1f556d3a26310188ebd8e4b36282b0970e617de9
5 years, 4 months ago (2015-08-12 13:21:33 UTC) #7
tandrii(chromium)
5 years, 4 months ago (2015-08-18 16:08:12 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1294023007/ by tandrii@chromium.org.

The reason for reverting is: Because we don't have and can't easily have
TryJobRietveld inside our master definition. So, let's not confuse people -
scheduling from Rietveld won't work.

See http://crbug.com/403494#42 for more..

Powered by Google App Engine
This is Rietveld 408576698