Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: lib/src/unparsed_frame.dart

Issue 1283113002: Don't throw for unparseable frames. (Closed) Base URL: git@github.com:dart-lang/stack_trace@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file.
4
5 library stack_trace.unparsed_frame;
6
7 import 'frame.dart';
8
9 /// A frame that failed to parse.
10 ///
11 /// The [member] property contains the original frame's contents.
12 class UnparsedFrame implements Frame {
13 final Uri uri = new Uri(path: "unparsed");
14 final int line = null;
15 final int column = null;
Bob Nystrom 2015/08/12 16:47:56 Do users expect that these are nullable? It may be
nweiz 2015/08/12 20:38:42 Yes, it's clearly documented in Frame and in pract
16 final bool isCore = false;
17 final String library = "unparsed";
18 final String package = null;
19 final String location = "unparsed";
20
21 final String member;
22
23 UnparsedFrame(this.member);
24
25 String toString() => _original;
26 }
OLDNEW
« CHANGELOG.md ('K') | « lib/src/trace.dart ('k') | lib/stack_trace.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698