Make gclient revert work with DEPS when DEPS url changes.

Make gclient revert work with DEPS when DEPS url changes.

BUG=520067
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296278

[tandrii(chromium), 2015-08-12 16:55:32]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-12 16:55:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283083003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283083003/1

[commit-bot: I haz the power, 2015-08-12 16:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-12 16:57:22]

Dry run: This issue passed the CQ dry run.

[nodir, 2015-08-12 17:04:26]

nodir@chromium.org changed reviewers:
+ nodir@chromium.org

[nodir, 2015-08-12 17:04:27]

https://codereview.chromium.org/1283083003/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1283083003/diff/1/gclient_scm.py#newcode725
gclient_scm.py:725: if 'safesync_url response "%s"' % deps_revision in
e.message:
Define a new exception class and raise it in lines 759 and 809
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/gcli...

[tandrii(chromium), 2015-08-12 17:17:34]

https://codereview.chromium.org/1283083003/diff/1/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1283083003/diff/1/gclient_scm.py#newcode725
gclient_scm.py:725: if 'safesync_url response "%s"' % deps_revision in
e.message:
On 2015/08/12 17:04:26, nodir wrote:
> Define a new exception class and raise it in lines 759 and 809
>
https://code.google.com/p/chromium/codesearch#chromium/tools/depot_tools/gcli...

Good idea, I was just lazy. Done.

[nodir, 2015-08-12 17:20:09]

lgtm

https://codereview.chromium.org/1283083003/diff/40001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1283083003/diff/40001/gclient_scm.py#newcode801
gclient_scm.py:801: raise NoUsableRevError(
Note that this was not catched before: it does not have "safesync_url response"
substring

https://codereview.chromium.org/1283083003/diff/40001/gclient_scm.py#newcode1603
gclient_scm.py:1603: ( '%s isn\'t a valid revision. Please check that your
safesync_url is\n'
this too

[M-A Ruel, 2015-08-12 17:25:10]

maruel@chromium.org changed reviewers:
+ maruel@chromium.org

[M-A Ruel, 2015-08-12 17:25:10]

lgtm

[tandrii(chromium), 2015-08-12 17:27:28]

https://codereview.chromium.org/1283083003/diff/40001/gclient_scm.py
File gclient_scm.py (right):

https://codereview.chromium.org/1283083003/diff/40001/gclient_scm.py#newcode801
gclient_scm.py:801: raise NoUsableRevError(
On 2015/08/12 17:20:08, nodir wrote:
> Note that this was not catched before: it does not have "safesync_url
response"
> substring
I am not sure about this case, but I thought PS2 is better than creating yet
another exception class just or this case.

https://codereview.chromium.org/1283083003/diff/40001/gclient_scm.py#newcode1603
gclient_scm.py:1603: ( '%s isn\'t a valid revision. Please check that your
safesync_url is\n'
On 2015/08/12 17:20:09, nodir wrote:
> this too

this is inside SVN scm block, so this was doesn't change things.

[tandrii(chromium), 2015-08-12 17:29:07]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2015-08-12 17:29:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283083003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283083003/40001

[tandrii(chromium), 2015-08-12 17:30:42]

The CQ bit was unchecked by tandrii@chromium.org

[tandrii(chromium), 2015-08-12 17:34:22]

The CQ bit was checked by tandrii@chromium.org

[tandrii(chromium), 2015-08-12 17:34:22]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org,
maruel@chromium.org
Link to the patchset: https://codereview.chromium.org/1283083003/#ps60001
(title: "more logging")

[commit-bot: I haz the power, 2015-08-12 17:34:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1283083003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1283083003/60001

[commit-bot: I haz the power, 2015-08-12 17:36:29]

Committed patchset #4 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296278