Issue 128303003: Prepare for including compositing reasons in GraphicsLayerDebugInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 128303003: Prepare for including compositing reasons in GraphicsLayerDebugInfo (Closed)

Created:
6 years, 11 months ago by Ian Vollick

Modified:
6 years, 11 months ago

Reviewers:
dsinclair

CC:
chromium-reviews, cc-bugs_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Prepare for including compositing reasons in GraphicsLayerDebugInfo Currently, the debug info is assumed to include only layout rects. This is a bummer. This CL allows for blink to return an arbitrary JSON object that will simply be merged into the base::DictionaryValue we populate for about::tracing. This will allow us to return arbitrary debug info for tracing from blink. BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243865

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -7 lines)			Patch
	M	cc/layers/layer_impl.cc	View		1 chunk	+24 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/128303003/1

6 years, 11 months ago (2014-01-08 20:46:07 UTC) #2

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=243875

6 years, 11 months ago (2014-01-09 04:09:24 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vollick@chromium.org/128303003/1

6 years, 11 months ago (2014-01-09 05:29:42 UTC) #4

Message was sent while issue was closed.

Change committed as 243865

Expand Messages | Collapse Messages