Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 128303002: Merged r18000, r18013, r18298, r18319 into 3.22 branch. (Closed)

Created:
6 years, 11 months ago by ulan
Modified:
6 years, 11 months ago
Reviewers:
Sven Panne, danno
CC:
v8-dev
Visibility:
Public.

Description

Merged r18000, r18013, r18298, r18319 into 3.22 branch. Restore saved caller FP registers on stub failure and preserve FP registers on NotifyStubFailure. Invalidate embedded objects in optimized code if it was marked for deoptimization. Initialize Date parse cache with SMI instead of double to workaround sharing mutable heap numbers in snapshot. Fix NotifyStubFailureSaveDoubles generation for ia32. BUG=320532, v8:2996, 280531 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18496

Patch Set 1 #

Patch Set 2 : Fix mips #

Unified diffs Side-by-side diffs Delta from patch set Stats (+325 lines, -118 lines) Patch
M src/arguments.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/arguments.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/arm/builtins-arm.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 6 chunks +43 lines, -21 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/builtins.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/date.js View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ia32/builtins-ia32.cc View 3 chunks +18 lines, -2 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 5 chunks +40 lines, -22 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/mips/builtins-mips.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.h View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 6 chunks +43 lines, -21 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/objects.cc View 1 chunk +12 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 3 chunks +13 lines, -2 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.h View 1 chunk +4 lines, -0 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 6 chunks +43 lines, -21 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +4 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-280531.js View 1 chunk +5 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
6 years, 11 months ago (2014-01-08 14:15:32 UTC) #1
ulan
Please take a look. All except src/x64/lithium-codegen.cc applied cleanly.
6 years, 11 months ago (2014-01-08 14:16:27 UTC) #2
Sven Panne
LGTM (rubberstamped)
6 years, 11 months ago (2014-01-08 14:26:56 UTC) #3
ulan
6 years, 11 months ago (2014-01-08 15:22:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r18496 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698