Don't use %p when generating disassembly in vm service.

runtime/vm/disassembler.cc

Index: runtime/vm/disassembler.cc
diff --git a/runtime/vm/disassembler.cc b/runtime/vm/disassembler.cc
index 80e1ff6e63adb8166aaa823e52350696cd7325bf..0224a07c4887c615858f78d279adf0bbf1f2fd64 100644
--- a/runtime/vm/disassembler.cc
+++ b/runtime/vm/disassembler.cc
@@ -46,12 +46,11 @@ void DisassembleToJSONStream::ConsumeInstruction(char* hex_buffer,
                                                  char* human_buffer,
                                                  intptr_t human_size,
                                                  uword pc) {
-  uint8_t* pc_ptr = reinterpret_cast<uint8_t*>(pc);
   // Instructions are represented as three consecutive values in a JSON array.
   // All three are strings. The first is the address of the instruction,
   // the second is the hex string of the code, and the final is a human
   // readable string.
-  jsarr_.AddValueF("%p", pc_ptr);
+  jsarr_.AddValueF("%" Px "", pc);

[Ivan Posva, 2015/08/11 01:17:40]

I don't think this is correct. As far as I know %p pads the number to pointer
size, which is not the case here. Do we need a Pd here?

   jsarr_.AddValue(hex_buffer);
   jsarr_.AddValue(human_buffer);
 }