runtime/observatory/tests/service/service.status - Issue 1282993002: Don't use %p when generating disassembly in vm service.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: runtime/observatory/tests/service/service.status

Issue 1282993002: Don't use %p when generating disassembly in vm service. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file	1 # Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file

2 # for details. All rights reserved. Use of this source code is governed by a	2 # for details. All rights reserved. Use of this source code is governed by a

3 # BSD-style license that can be found in the LICENSE file.	3 # BSD-style license that can be found in the LICENSE file.

4	4

5 [ $compiler == none && $runtime == vm ]	5 [ $compiler == none && $runtime == vm ]

6 evaluate_activation_test/instance: RuntimeError # http://dartbug.com/20047	6 evaluate_activation_test/instance: RuntimeError # http://dartbug.com/20047

7 evaluate_activation_test/scope: RuntimeError # http://dartbug.com/20047	7 evaluate_activation_test/scope: RuntimeError # http://dartbug.com/20047

8	8

9 # Unexpected number format: http://dartbug.com/24038

10 [ $system == windows ]

11 code_test: Skip

12

13 # Disable on simulators.	9 # Disable on simulators.

14 [ $arch == simarm \|\| $arch == simmips \|\| $arch == simarm64]	10 [ $arch == simarm \|\| $arch == simmips \|\| $arch == simarm64]

15 *: SkipSlow	11 *: SkipSlow

16	12

17 # All tests use dart:io	13 # All tests use dart:io

18 [ $browser \|\| $compiler == dart2js ]	14 [ $browser \|\| $compiler == dart2js ]

19 *: SkipByDesign	15 *: SkipByDesign

OLD	NEW