Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(671)

Issue 1282973004: gpu: Crash GPU process when context was lost through robustness (Closed)

Created:
5 years, 4 months ago by no sievers
Modified:
5 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, piman+watch_chromium.org, vmiura
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Crash GPU process when context was lost through robustness This works around both recovery problems in drivers as well as in our recovery flow (480545). Note that this is already the default behavior on Windows. BUG=458269, 475676, 503414, 480545 Committed: https://crrev.com/751a98d265bf854b6b6d216fb7d20ef6ec1313c8 Cr-Commit-Position: refs/heads/master@{#342928}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -17 lines) Patch
M content/common/gpu/gpu_command_buffer_stub.cc View 1 chunk +25 lines, -17 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
no sievers
ptal. Seems to do wonders on Qualcomm also as manually tested. We can later look ...
5 years, 4 months ago (2015-08-11 00:22:12 UTC) #2
Ken Russell (switch to Gerrit)
This looks generally good but I wonder would it be better to put in a ...
5 years, 4 months ago (2015-08-11 16:53:15 UTC) #3
jbauman
lgtm. I think it makes sense to have this as the default until we're sure ...
5 years, 4 months ago (2015-08-11 23:07:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282973004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282973004/1
5 years, 4 months ago (2015-08-11 23:15:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-11 23:23:18 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 23:24:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/751a98d265bf854b6b6d216fb7d20ef6ec1313c8
Cr-Commit-Position: refs/heads/master@{#342928}

Powered by Google App Engine
This is Rietveld 408576698