Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282923005: Remove Android filter file for sync_unit_tests. (Closed)

Created:
5 years, 4 months ago by tfarina
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, yfriedman+watch_chromium.org, zea+watch_chromium.org, Nicolas Zea
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Android filter file for sync_unit_tests. BUG=339980 TEST=sync_unit_tests R=jbudorick@chromium.org,atwilson@chromium.org Committed: https://crrev.com/1c2f3def31972837b72d970e25417b913df74b7a Cr-Commit-Position: refs/heads/master@{#343011}

Patch Set 1 #

Patch Set 2 : SyncHttpBridgeTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -31 lines) Patch
M build/android/pylib/gtest/filter/sync_unit_tests_disabled View 1 1 chunk +0 lines, -4 lines 0 comments Download
M sync/internal_api/http_bridge_unittest.cc View 1 17 chunks +30 lines, -26 lines 0 comments Download
M sync/syncable/syncable_unittest.cc View 1 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
tfarina
John -> build Andrew -> sync PTAL
5 years, 4 months ago (2015-08-11 16:47:38 UTC) #2
jbudorick
build/android/ lgtm
5 years, 4 months ago (2015-08-11 16:48:53 UTC) #3
Andrew T Wilson (Slow)
lgtm
5 years, 4 months ago (2015-08-12 12:10:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282923005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282923005/20001
5 years, 4 months ago (2015-08-12 13:30:14 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 13:35:18 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 13:35:53 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/1c2f3def31972837b72d970e25417b913df74b7a
Cr-Commit-Position: refs/heads/master@{#343011}

Powered by Google App Engine
This is Rietveld 408576698