Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 12829005: Fix OS_MACOS typos. Should be OS_MACOSX. (Closed)

Created:
7 years, 9 months ago by DaleCurtis
Modified:
7 years, 9 months ago
Reviewers:
James Cook, brettw, jeremy
CC:
chromium-reviews, Raman Kakilate, jam, rdsmith+dwatch_chromium.org, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, joi+watch-content_chromium.org, benjhayden+dwatch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, erikwright+watch_chromium.org, Ilya Sherman, Nico, M-A Ruel, jeremy
Visibility:
Public.

Description

Fix OS_MACOS typos. Should be OS_MACOSX. BUG=163208 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=189130

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase. #

Total comments: 3

Patch Set 3 : Remove section. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -26 lines) Patch
M base/path_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autofill/autofill_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_path_reservation_tracker_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser_command_controller_unittest.cc View 1 2 2 chunks +2 lines, -23 lines 0 comments Download

Messages

Total messages: 16 (0 generated)
DaleCurtis
brettw: Looks like you have the honor of covering OWNERS for all these.
7 years, 9 months ago (2013-03-13 23:03:04 UTC) #1
Dan Beam
A presubmit check for this might be handy. I've done a CL or two previously ...
7 years, 9 months ago (2013-03-13 23:06:56 UTC) #2
brettw
lgtm
7 years, 9 months ago (2013-03-14 04:25:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/12829005/1
7 years, 9 months ago (2013-03-14 17:51:51 UTC) #4
DaleCurtis
dbeam: I don't see a global presubmit class of error which means "Did you really ...
7 years, 9 months ago (2013-03-14 17:56:18 UTC) #5
Dan Beam
I think the header sorting one is a pretty good example of something we know ...
7 years, 9 months ago (2013-03-14 18:23:34 UTC) #6
DaleCurtis
Doh, compile is failing on Mac, looks like the SandboxInit wants some arguments. +jeremy who ...
7 years, 9 months ago (2013-03-14 18:24:36 UTC) #7
DaleCurtis
Whoops, actually +jeremy this time.
7 years, 9 months ago (2013-03-14 18:24:58 UTC) #8
jeremy
https://codereview.chromium.org/12829005/diff/1/content/worker/worker_main.cc File content/worker/worker_main.cc (right): https://codereview.chromium.org/12829005/diff/1/content/worker/worker_main.cc#newcode46 content/worker/worker_main.cc:46: #elif defined(OS_MACOSX) Per separate email, this should be fixed ...
7 years, 9 months ago (2013-03-19 10:06:39 UTC) #9
DaleCurtis
Thanks, rebased!
7 years, 9 months ago (2013-03-19 17:45:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/12829005/20001
7 years, 9 months ago (2013-03-19 17:48:14 UTC) #11
DaleCurtis
https://codereview.chromium.org/12829005/diff/20001/chrome/browser/ui/browser_command_controller_unittest.cc File chrome/browser/ui/browser_command_controller_unittest.cc (right): https://codereview.chromium.org/12829005/diff/20001/chrome/browser/ui/browser_command_controller_unittest.cc#newcode258 chrome/browser/ui/browser_command_controller_unittest.cc:258: #if defined(OS_MACOSX) +jamescook this test is failing on the ...
7 years, 9 months ago (2013-03-19 19:36:49 UTC) #12
James Cook
https://codereview.chromium.org/12829005/diff/20001/chrome/browser/ui/browser_command_controller_unittest.cc File chrome/browser/ui/browser_command_controller_unittest.cc (right): https://codereview.chromium.org/12829005/diff/20001/chrome/browser/ui/browser_command_controller_unittest.cc#newcode258 chrome/browser/ui/browser_command_controller_unittest.cc:258: #if defined(OS_MACOSX) On 2013/03/19 19:36:50, DaleCurtis wrote: > +jamescook ...
7 years, 9 months ago (2013-03-19 20:21:01 UTC) #13
DaleCurtis
https://codereview.chromium.org/12829005/diff/20001/chrome/browser/ui/browser_command_controller_unittest.cc File chrome/browser/ui/browser_command_controller_unittest.cc (right): https://codereview.chromium.org/12829005/diff/20001/chrome/browser/ui/browser_command_controller_unittest.cc#newcode258 chrome/browser/ui/browser_command_controller_unittest.cc:258: #if defined(OS_MACOSX) On 2013/03/19 20:21:01, James Cook (Chromium) wrote: ...
7 years, 9 months ago (2013-03-19 20:26:37 UTC) #14
James Cook
lgtm
7 years, 9 months ago (2013-03-19 20:28:40 UTC) #15
DaleCurtis
7 years, 9 months ago (2013-03-19 22:07:04 UTC) #16
Message was sent while issue was closed.
Committed patchset #3 manually as r189130 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698