Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 1282893002: Make initBatchTracker private, move towards pipeline on batch (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, brucedawson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make initBatchTracker private, move towards pipeline on batch Committed: https://skia.googlesource.com/skia/+/5ac42ea8079c9368430971943192772984da5fce

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -32 lines) Patch
M src/gpu/GrBufferedDrawTarget.cpp View 2 chunks +1 line, -3 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +4 lines, -2 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 3 chunks +14 lines, -12 lines 1 comment Download
M src/gpu/GrTargetCommands.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 3 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bsalomon
5 years, 4 months ago (2015-08-10 19:25:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282893002/1
5 years, 4 months ago (2015-08-10 19:29:44 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-10 19:29:44 UTC) #5
joshualitt
On 2015/08/10 19:29:44, commit-bot: I haz the power wrote: > Note for Reviewers: > The ...
5 years, 4 months ago (2015-08-10 20:02:33 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/5ac42ea8079c9368430971943192772984da5fce
5 years, 4 months ago (2015-08-10 20:03:54 UTC) #7
brucedawson
5 years, 4 months ago (2015-08-11 18:57:39 UTC) #9
Message was sent while issue was closed.
https://codereview.chromium.org/1282893002/diff/1/src/gpu/GrReorderCommandBui...
File src/gpu/GrReorderCommandBuilder.cpp (right):

https://codereview.chromium.org/1282893002/diff/1/src/gpu/GrReorderCommandBui...
src/gpu/GrReorderCommandBuilder.cpp:27: int i = 0;
If this variable was declared on line 52 then it wouldn't be shadowed by the two
'i' declarations on lines 40 and 44.

This isn't a bug, but the large gap between the declaration of 'i' and its first
use is suboptimal for readability, so line 52 is definitely a better location.

I only noticed this because the newly added 'for' loops triggered two variable
shadowing warnings in /analyze. FWIW.

Powered by Google App Engine
This is Rietveld 408576698