Move service extension handler execution to a timer

runtime/vm/service.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/service.h"
 
 #include "include/dart_api.h"
 #include "include/dart_native_api.h"
 #include "platform/globals.h"
 
@@ skipping 567 matching lines @@
     if (handler == NULL) {
       handler = FindRootEmbedderHandler(c_method_name);
     }
 
     if (handler != NULL) {
       EmbedderHandleMessage(handler, &js);
       js.PostReply();
       return;
     }
 
-    if (ExtensionHandlerExists(method_name)) {
-      InvokeExtensionHandler(method_name,
-                             param_keys,
-                             param_values,
-                             reply_port,
-                             seq);
-      // The reply is posted asynchronously.
+    if (ScheduleExtensionHandler(method_name,
+                                 param_keys,
+                                 param_values,
+                                 reply_port,
+                                 seq)) {
+      // Schedule was successful. Extension code will post a reply
+      // asynchronously.
       return;
     }
 
     PrintUnrecognizedMethodError(&js);
     js.PostReply();
     return;
   }
 }
 
 
@@ skipping 267 matching lines @@
   while (current != NULL) {
     if (strcmp(name, current->name()) == 0) {
       return current;
     }
     current = current->next();
   }
   return NULL;
 }
 
 
-bool Service::ExtensionHandlerExists(const String& method) {
-  ASSERT(!method.IsNull());
-  const Library& developer_lib = Library::Handle(Library::DeveloperLibrary());
-  ASSERT(!developer_lib.IsNull());
-  const Function& extension_exists = Function::Handle(
-      developer_lib.LookupLocalFunction(Symbols::_extensionExists()));
-  ASSERT(!extension_exists.IsNull());
-  const Array& arguments = Array::Handle(Array::New(1));
-  ASSERT(!arguments.IsNull());
-  arguments.SetAt(0, method);
-  return (DartEntry::InvokeFunction(extension_exists, arguments) ==
-          Object::bool_true().raw());
-}
-
-
-bool Service::InvokeExtensionHandler(const String& method_name,
-                                     const Array& parameter_keys,
-                                     const Array& parameter_values,
-                                     const Instance& reply_port,
-                                     const Instance& id) {
+bool Service::ScheduleExtensionHandler(const String& method_name,
+                                       const Array& parameter_keys,
+                                       const Array& parameter_values,
+                                       const Instance& reply_port,
+                                       const Instance& id) {
   ASSERT(!method_name.IsNull());
   ASSERT(!parameter_keys.IsNull());
   ASSERT(!parameter_values.IsNull());
   ASSERT(!reply_port.IsNull());
   const Library& developer_lib = Library::Handle(Library::DeveloperLibrary());
   ASSERT(!developer_lib.IsNull());
-  const Function& invoke_extension = Function::Handle(
-      developer_lib.LookupLocalFunction(Symbols::_invokeExtension()));
-  ASSERT(!invoke_extension.IsNull());
+  const Function& schedule_extension = Function::Handle(
+      developer_lib.LookupLocalFunction(Symbols::_scheduleExtension()));
+  ASSERT(!schedule_extension.IsNull());
   const Array& arguments = Array::Handle(Array::New(5));
   arguments.SetAt(0, method_name);
   arguments.SetAt(1, parameter_keys);
   arguments.SetAt(2, parameter_values);
   arguments.SetAt(3, reply_port);
   arguments.SetAt(4, id);
-  return (DartEntry::InvokeFunction(invoke_extension, arguments) ==
+  return (DartEntry::InvokeFunction(schedule_extension, arguments) ==
           Object::bool_true().raw());
 }
 
 
 static const MethodParameter* get_isolate_params[] = {
   ISOLATE_PARAMETER,
   NULL,
 };
 
 
@@ skipping 2206 matching lines @@
     ServiceMethodDescriptor& method = service_methods_[i];
     if (strcmp(method_name, method.name) == 0) {
       return &method;
     }
   }
   return NULL;
 }
 
 
 }  // namespace dart