Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Unified Diff: pkg/analyzer/test/file_system/physical_resource_provider_test.dart

Issue 1282873002: Revert a work-around that is now causing bot failures (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/file_system/physical_resource_provider_test.dart
diff --git a/pkg/analyzer/test/file_system/physical_resource_provider_test.dart b/pkg/analyzer/test/file_system/physical_resource_provider_test.dart
index 6862c7185ebfd8cc9117a0048be2b5b094e55b0a..6cda64efb6aad9f56a30619e5c0d9ba58f0cc91d 100644
--- a/pkg/analyzer/test/file_system/physical_resource_provider_test.dart
+++ b/pkg/analyzer/test/file_system/physical_resource_provider_test.dart
@@ -297,14 +297,7 @@ class PhysicalResourceProviderTest extends _BaseTest {
file.deleteSync();
return _delayed(() {
expect(changesReceived, hasLength(1));
- if (io.Platform.isWindows) {
- // TODO(danrubel) https://github.com/dart-lang/sdk/issues/23762
- // This test fails on Windows but a similar test in the underlying
- // watcher package passes on Windows.
- expect(changesReceived[0].type, equals(ChangeType.MODIFY));
- } else {
- expect(changesReceived[0].type, equals(ChangeType.REMOVE));
- }
+ expect(changesReceived[0].type, equals(ChangeType.REMOVE));
expect(changesReceived[0].path, equals(path));
});
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698