Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: mojo/devtools/common/devtoolslib/android_shell.py

Issue 1282863002: Don't require `--origin` when running on Android anymore. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/devtools/common/devtoolslib/android_shell.py
diff --git a/mojo/devtools/common/devtoolslib/android_shell.py b/mojo/devtools/common/devtoolslib/android_shell.py
index e07ce773a43795995594f452b8f0fa21b7ded0a4..f5a1fa8983f48b0c0f4cb3e793c8d35b2681892f 100644
--- a/mojo/devtools/common/devtoolslib/android_shell.py
+++ b/mojo/devtools/common/devtoolslib/android_shell.py
@@ -279,9 +279,7 @@ class AndroidShell(Shell):
"""Starts the mojo shell, passing it the given arguments.
Args:
- arguments: List of arguments for the shell. It must contain the
- "--origin=" arg. shell_arguments.configure_local_origin() can be used
- to set up a local directory on the host machine as origin.
+ arguments: List of arguments for the shell.
stdout: Valid argument for subprocess.Popen() or None.
"""
if not self.stop_shell_registered:
@@ -310,8 +308,6 @@ class AndroidShell(Shell):
else:
_logger.warning("Running without root access, full stdout of the "
"shell won't be available.")
- # The origin has to be specified whether it's local or external.
- assert any("--origin=" in arg for arg in arguments)
parameters.extend(arguments)
if parameters:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698