chrome/browser/chromeos/input_method/input_method_engine_interface.h - Issue 1282823002: Add text offset to OnSurroundingTextChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_interface.h

Issue 1282823002: Add text offset to OnSurroundingTextChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer feedback. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc ('k') | chrome/browser/chromeos/input_method/input_method_engine_unittest.cc » ('j') | chrome/common/extensions/api/input_ime.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_interface.h

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_interface.h b/chrome/browser/chromeos/input_method/input_method_engine_interface.h

index b183a3d4442e8e03509530e4b5eb93c420681901..bf5484202f509f12fdfb10399c8c454c6d2d1583 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_interface.h

+++ b/chrome/browser/chromeos/input_method/input_method_engine_interface.h

@@ -171,7 +171,8 @@ class InputMethodEngineInterface : public IMEEngineHandlerInterface {

virtual void OnSurroundingTextChanged(const std::string& engine_id,

const std::string& text,

int cursor_pos,

- int anchor_pos) = 0;

+ int anchor_pos,

+ int offset_pos) = 0;

// Called when composition bounds are changed.

virtual void OnCompositionBoundsChanged(