ui/base/ime/input_method_chromeos.cc - Issue 1282823002: Add text offset to OnSurroundingTextChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/ime/input_method_chromeos.cc

Issue 1282823002: Add text offset to OnSurroundingTextChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer feedback. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/ime/input_method_chromeos.cc

diff --git a/ui/base/ime/input_method_chromeos.cc b/ui/base/ime/input_method_chromeos.cc

index c624a0fc20bd63dae859f4e05ad50bf2196f79b3..9730068c9c5f7244ab5de5f8557622be1c02b819 100644

--- a/ui/base/ime/input_method_chromeos.cc

+++ b/ui/base/ime/input_method_chromeos.cc

@@ -241,7 +241,8 @@ void InputMethodChromeOS::OnCaretBoundsChanged(const TextInputClient* client) {

return;

GetEngine()->SetSurroundingText(base::UTF16ToUTF8(surrounding_text),

selection_range.start() - text_range.start(),

- selection_range.end() - text_range.start());

+ selection_range.end() - text_range.start(),

+ client->GetTextOffset());

}

void InputMethodChromeOS::CancelComposition(const TextInputClient* client) {