chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc - Issue 1282823002: Add text offset to OnSurroundingTextChanged

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

Issue 1282823002: Add text offset to OnSurroundingTextChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address reviewer feedback. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/input_method/input_method_engine.cc ('k') | chrome/browser/chromeos/input_method/input_method_engine_interface.h » ('j') | content/browser/renderer_host/render_widget_host_view_aura.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

diff --git a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

index b21d737fc692b1ce6b05af01ebbb9ff72d7381bb..677025ff47a72331ac1b8b91d1aa035b99e7f2f1 100644

--- a/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

+++ b/chrome/browser/chromeos/input_method/input_method_engine_browsertests.cc

@@ -194,8 +194,9 @@ IN_PROC_BROWSER_TEST_P(InputMethodEngineBrowserTest,

ExtensionTestMessageListener surrounding_text_listener(

"onSurroundingTextChanged", false);

engine_handler->SetSurroundingText("text", // Surrounding text.

- 0, // focused position.

- 1); // anchor position.

+ 0, // focused position.

+ 1, // anchor position.

+ 0); // offset position.

ASSERT_TRUE(surrounding_text_listener.WaitUntilSatisfied());

ASSERT_TRUE(surrounding_text_listener.was_satisfied());