Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: ui/views/controls/textfield/textfield.cc

Issue 1282823002: Add text offset to OnSurroundingTextChanged (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix formatting. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ui/base/ime/text_input_client.h ('K') | « ui/views/controls/textfield/textfield.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/textfield/textfield.cc
diff --git a/ui/views/controls/textfield/textfield.cc b/ui/views/controls/textfield/textfield.cc
index 4ae5f1acbc167a1f0a5d38ddf55cdc471cec525a..e67c8c4ae05172a41e8d1fb7215a94b7c86d1336 100644
--- a/ui/views/controls/textfield/textfield.cc
+++ b/ui/views/controls/textfield/textfield.cc
@@ -1558,6 +1558,10 @@ bool Textfield::SetSelectionRange(const gfx::Range& range) {
return true;
}
+uint32 Textfield::GetSelectionOffset() const {
+ return 0;
Shu Chen 2015/08/12 07:23:16 Why always return 0?
rsadam 2015/08/12 21:46:52 From my understanding textfield.h is for all nativ
Shu Chen 2015/08/13 01:27:24 Let's not change the existing behavior for now. Re
+}
+
bool Textfield::DeleteRange(const gfx::Range& range) {
if (!ImeEditingAllowed() || range.is_empty())
return false;
« ui/base/ime/text_input_client.h ('K') | « ui/views/controls/textfield/textfield.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698