Add text offset to OnSurroundingTextChanged

ui/base/ime/chromeos/ime_bridge.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef UI_BASE_IME_CHROMEOS_IME_BRIDGE_H_
 #define UI_BASE_IME_CHROMEOS_IME_BRIDGE_H_
 
 #include <string>
 #include <vector>
 #include "base/basictypes.h"
@@ skipping 81 matching lines @@
   virtual void ProcessKeyEvent(const ui::KeyEvent& key_event,
                                const KeyEventDoneCallback& callback) = 0;
 
   // Called when the candidate in lookup table is clicked. The |index| is 0
   // based candidate index in lookup table.
   virtual void CandidateClicked(uint32 index) = 0;
 
   // Called when a new surrounding text is set. The |text| is surrounding text
   // and |cursor_pos| is 0 based index of cursor position in |text|. If there is
   // selection range, |anchor_pos| represents opposite index from |cursor_pos|.
-  // Otherwise |anchor_pos| is equal to |cursor_pos|.
-  virtual void SetSurroundingText(const std::string& text, uint32 cursor_pos,
-                                  uint32 anchor_pos) = 0;
+  // Otherwise |anchor_pos| is equal to |cursor_pos|. If not all surrounding
+  // text is given |offset_pos| indicates the starting offset of |text|.

[Shu Chen, 2015/08/12 07:23:16]

Here is "offset of |text|", but in input_ime.json it is "offset of selection".
Which is correct?

[rsadam, 2015/08/12 21:46:52]

Should be offset of |text|. Fixed.

+  virtual void SetSurroundingText(const std::string& text,
+                                  uint32 cursor_pos,
+                                  uint32 anchor_pos,
+                                  uint32 offset_pos) = 0;
 
   // Called when the composition bounds changed.
   virtual void SetCompositionBounds(const std::vector<gfx::Rect>& bounds) = 0;
 
   // Returns whether the engine is interested in key events.
   // If not, InputMethodChromeOS won't feed it with key events.
   virtual bool IsInterestedInKeyEvent() const = 0;
 
  protected:
   IMEEngineHandlerInterface() {}
@@ skipping 82 matching lines @@
  protected:
   IMEBridge();
 
  private:
   DISALLOW_COPY_AND_ASSIGN(IMEBridge);
 };
 
 }  // namespace chromeos
 
 #endif  // UI_BASE_IME_CHROMEOS_IME_BRIDGE_H_