Issue 12828008: Fix up platform macros.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12828008: Fix up platform macros. (Closed)

Created:
7 years, 9 months ago by groby-ooo-7-16

Modified:
7 years, 9 months ago

Reviewers:
James Hawkins

CC:
chromium-reviews, Raman Kakilate, rdsmith+dwatch_chromium.org, benquan, dhollowa+watch_chromium.org, ahutter, browser-components-watch_chromium.org, dbeam+watch-autofill_chromium.org, benjhayden+dwatch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Albert Bodenhamer, erikwright+watch_chromium.org, Ilya Sherman

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix up platform macros. TBR=jhawkins@chromium.org BUG=none

Patch Set 1 #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	base/path_service_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/autofill/autofill_browsertest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/download/download_path_reservation_tracker_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/12828008/1

7 years, 9 months ago (2013-03-19 22:13:32 UTC) #2

commit-bot: I haz the power

7 years, 9 months ago (2013-03-19 22:13:34 UTC) #3

Failed to apply patch for base/path_service_unittest.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file base/path_service_unittest.cc
  Hunk #1 FAILED at 62.
  1 out of 1 hunk FAILED -- saving rejects to file
base/path_service_unittest.cc.rej

Patch:       base/path_service_unittest.cc
Index: base/path_service_unittest.cc
diff --git a/base/path_service_unittest.cc b/base/path_service_unittest.cc
index
8ae41780cb249dc83ad1487d6da99cde133aabf5..5f281d129df93d16b739e0d510cc3be239a0e63a
100644
--- a/base/path_service_unittest.cc
+++ b/base/path_service_unittest.cc
@@ -62,7 +62,7 @@ bool ReturnsValidPath(int dir_type) {
       check_path_exists = false;
   }
 #endif
-#if defined(OS_MAC)
+#if defined(OS_MACOSX)
   if (dir_type != base::DIR_EXE && dir_type != base::DIR_MODULE &&
       dir_type != base::FILE_EXE && dir_type != base::FILE_MODULE) {
     if (path.ReferencesParent())

Expand Messages | Collapse Messages