Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282793002: Debugger: load debugger builtins as normal native JS. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: load debugger builtins as normal native JS. R=jkummerow@chromium.org Committed: https://crrev.com/5df7d689eb3b1ad73ed673c356bab85766d15700 Cr-Commit-Position: refs/heads/master@{#30136}

Patch Set 1 #

Total comments: 3

Patch Set 2 : use InstallFunctions and InstallConstants #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -365 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 6 chunks +18 lines, -5 lines 0 comments Download
M src/debug/debug.h View 2 chunks +5 lines, -1 line 0 comments Download
M src/debug/debug.cc View 6 chunks +16 lines, -104 lines 0 comments Download
M src/debug/debug.js View 1 49 chunks +140 lines, -86 lines 0 comments Download
M src/debug/debug-evaluate.cc View 1 chunk +1 line, -5 lines 0 comments Download
M src/debug/liveedit.js View 19 chunks +48 lines, -32 lines 0 comments Download
M src/debug/mirrors.js View 1 46 chunks +206 lines, -125 lines 0 comments Download
M src/messages.h View 2 chunks +3 lines, -0 lines 0 comments Download
M src/prologue.js View 2 chunks +17 lines, -0 lines 0 comments Download
M src/string.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/debug-mirror-cache.js View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282793002/1
5 years, 4 months ago (2015-08-10 11:13:37 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-10 11:38:36 UTC) #4
Yang
On 2015/08/10 11:38:36, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
5 years, 4 months ago (2015-08-12 10:19:21 UTC) #5
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js File src/debug/mirrors.js (right): https://codereview.chromium.org/1282793002/diff/1/src/debug/mirrors.js#newcode20 src/debug/mirrors.js:20: // - ValueMirror nit: meaningful indentation ...
5 years, 4 months ago (2015-08-12 12:47:51 UTC) #6
Yang
Addressed comments. I switched to using InstallFunctions where I can and InstallConstants where I cannot ...
5 years, 4 months ago (2015-08-12 13:57:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282793002/20001
5 years, 4 months ago (2015-08-12 13:57:27 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-12 14:22:12 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 14:22:30 UTC) #12
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/5df7d689eb3b1ad73ed673c356bab85766d15700
Cr-Commit-Position: refs/heads/master@{#30136}

Powered by Google App Engine
This is Rietveld 408576698