Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 12827007: Support initialized mixin fields across scripts (Closed)

Created:
7 years, 9 months ago by hausner
Modified:
7 years, 9 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support initialized mixin fields across scripts Add capability to set parser to read tokens from different scripts and token positions. This is used when the initializer expression of a field resides in a different script. Committed: https://code.google.com/p/dart/source/detail?r=20388

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -27 lines) Patch
M runtime/vm/datastream.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +15 lines, -1 line 0 comments Download
M runtime/vm/parser.h View 1 4 chunks +9 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 6 chunks +58 lines, -21 lines 0 comments Download
M tests/language/language.status View 1 1 chunk +0 lines, -1 line 0 comments Download
A tests/language/mixin_field_initializer_test.dart View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 9 months ago (2013-03-21 21:09:40 UTC) #1
siva
lgtm https://chromiumcodereview.appspot.com/12827007/diff/1/runtime/vm/parser.cc File runtime/vm/parser.cc (right): https://chromiumcodereview.appspot.com/12827007/diff/1/runtime/vm/parser.cc#newcode1854 runtime/vm/parser.cc:1854: SetScript(Script::Handle(current_class().script()), field.token_pos()); It would probably be much more ...
7 years, 9 months ago (2013-03-22 16:47:56 UTC) #2
hausner
Committed patchset #2 manually as r20388 (presubmit successful).
7 years, 9 months ago (2013-03-22 17:06:51 UTC) #3
hausner
7 years, 9 months ago (2013-03-22 17:11:06 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/12827007/diff/1/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/12827007/diff/1/runtime/vm/parser.cc#newcode1854
runtime/vm/parser.cc:1854: SetScript(Script::Handle(current_class().script()),
field.token_pos());
On 2013/03/22 16:47:56, siva wrote:
> It would probably be much more readable if you clubbed all the save statements
> together and then did the set statements
> (kind of like the way you have it below when you restore it).

Done.

Powered by Google App Engine
This is Rietveld 408576698