Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 128263007: Add myself to chrome/browser/apps owners. (Closed)

Created:
6 years, 11 months ago by not at google - send to devlin
Modified:
6 years, 11 months ago
Reviewers:
benwells
CC:
chromium-reviews
Visibility:
Public.

Description

Add myself to chrome/browser/apps owners. R=benwells@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244006

Patch Set 1 #

Total comments: 2

Patch Set 2 : more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/browser/apps/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/apps/OWNERS View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
not at google - send to devlin
6 years, 11 months ago (2014-01-09 00:33:23 UTC) #1
benwells
Also: src/apps chrome/browser/ui/apps https://codereview.chromium.org/128263007/diff/1/chrome/browser/apps/OWNERS File chrome/browser/apps/OWNERS (right): https://codereview.chromium.org/128263007/diff/1/chrome/browser/apps/OWNERS#newcode7 chrome/browser/apps/OWNERS:7: kalman@chromium.org Nit: keep alphabeticized
6 years, 11 months ago (2014-01-09 02:36:48 UTC) #2
not at google - send to devlin
added to ui owners, already in apps owners. https://codereview.chromium.org/128263007/diff/1/chrome/browser/apps/OWNERS File chrome/browser/apps/OWNERS (right): https://codereview.chromium.org/128263007/diff/1/chrome/browser/apps/OWNERS#newcode7 chrome/browser/apps/OWNERS:7: kalman@chromium.org ...
6 years, 11 months ago (2014-01-09 16:05:59 UTC) #3
benwells
lgtm
6 years, 11 months ago (2014-01-09 22:39:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/128263007/60001
6 years, 11 months ago (2014-01-09 22:41:04 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 22:46:43 UTC) #6
Message was sent while issue was closed.
Change committed as 244006

Powered by Google App Engine
This is Rietveld 408576698