chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java - Issue 1282603005: Convert ChromeSyncShell to use ChromePublic infrastructure

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

Issue 1282603005: Convert ChromeSyncShell to use ChromePublic infrastructure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/chrome_apk.gyp ('K') | « chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java ('k') | chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h » ('j') | chrome/android/sync_shell/javatests/AndroidManifest.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

index 9aa6b9d12f5c02a11452b0681047a64df71110f7..300b848a493d5d9559bb361fdea8a87b42f9b38c 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java

@@ -15,6 +15,7 @@ import org.chromium.base.ApplicationState;

import org.chromium.base.ApplicationStatus;

import org.chromium.base.ApplicationStatus.ApplicationStateListener;

import org.chromium.base.ThreadUtils;

+import org.chromium.base.VisibleForTesting;

import org.chromium.chrome.browser.identity.UniqueIdentificationGeneratorFactory;

import org.chromium.chrome.browser.invalidation.InvalidationController;

import org.chromium.chrome.browser.signin.AccountManagementFragment;

@@ -112,6 +113,7 @@ public class SyncController implements ApplicationStateListener,

* @param activity the current activity.

* @param accountName the full account name.

+ @VisibleForTesting

public void signIn(Activity activity, String accountName) {

final Account account = AccountManagerHelper.createAccountFromName(accountName);