Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1282603005: Convert ChromeSyncShell to use ChromePublic infrastructure (Closed)

Created:
5 years, 4 months ago by pval...(no longer on Chromium)
Modified:
5 years, 4 months ago
Reviewers:
jbudorick, newt (away)
CC:
chromium-reviews, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ChromeSyncShell to use ChromePublic infrastructure Several test fixes are included to support this change. Note: This CL only provides a GYP implementation (no GN). This is not a regression from the previous state. BUG=510211 Committed: https://crrev.com/62ca3f0326203cca221bba6f0ee038ff292ecc66 Cr-Commit-Position: refs/heads/master@{#344128}

Patch Set 1 #

Total comments: 14

Patch Set 2 : remove test deps from ChromeSyncShell #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : fix test #

Patch Set 6 : fix testDefaultEncryptionOptions #

Patch Set 7 : yet another rebase #

Patch Set 8 : re-land version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -485 lines) Patch
M build/all.gyp View 1 2 3 4 5 6 7 2 chunks +2 lines, -2 lines 0 comments Download
M build/get_landmines.py View 1 2 3 4 5 6 7 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/BUILD.gn View 1 2 3 4 5 6 7 3 chunks +0 lines, -69 lines 0 comments Download
M chrome/android/chrome_apk.gyp View 1 2 3 4 5 6 7 8 chunks +170 lines, -12 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ProfileSyncService.java View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/SyncController.java View 1 2 3 4 5 6 7 2 chunks +2 lines, -0 lines 0 comments Download
D chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/android/sync_shell/chrome_main_delegate_chrome_sync_shell_android.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/android/sync_shell/java/AndroidManifest.xml.jinja2 View 1 2 3 4 5 6 7 1 chunk +0 lines, -158 lines 0 comments Download
M chrome/android/sync_shell/javatests/AndroidManifest.xml View 1 2 3 4 5 6 7 2 chunks +18 lines, -16 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/FirstRunTest.java View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 4 chunks +12 lines, -22 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncCustomizationFragmentTest.java View 1 2 3 4 5 7 chunks +32 lines, -33 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTest.java View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java View 1 2 3 4 chunks +18 lines, -12 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/TypedUrlsTest.java View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/android/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/android/chrome_sync_shell_main_delegate.h View 1 2 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/android/chrome_sync_shell_main_delegate.cc View 1 2 1 chunk +24 lines, -0 lines 0 comments Download
A + chrome/browser/android/chrome_sync_shell_main_delegate_initializer.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_shell.gypi View 2 chunks +0 lines, -65 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 7 1 chunk +0 lines, -25 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockAccountManager.java View 4 chunks +4 lines, -0 lines 0 comments Download
M sync/test/android/javatests/src/org/chromium/sync/test/util/MockSyncContentResolverDelegate.java View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (9 generated)
pval...(no longer on Chromium)
5 years, 4 months ago (2015-08-11 01:45:41 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282603005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282603005/1
5 years, 4 months ago (2015-08-11 19:52:05 UTC) #4
newt (away)
Looks generally good. A few comments inline. https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp File chrome/android/chrome_apk.gyp (right): https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp#newcode253 chrome/android/chrome_apk.gyp:253: '../../base/base.gyp:base_java_test_support', why ...
5 years, 4 months ago (2015-08-11 21:25:30 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/54494)
5 years, 4 months ago (2015-08-11 22:17:42 UTC) #7
pval...(no longer on Chromium)
https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp File chrome/android/chrome_apk.gyp (right): https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp#newcode253 chrome/android/chrome_apk.gyp:253: '../../base/base.gyp:base_java_test_support', On 2015/08/11 21:25:29, newt wrote: > why are ...
5 years, 4 months ago (2015-08-12 23:25:59 UTC) #8
newt (away)
On 2015/08/12 23:25:59, pvalenzuela wrote: > https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp > File chrome/android/chrome_apk.gyp (right): > > https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp#newcode253 > ...
5 years, 4 months ago (2015-08-13 00:28:03 UTC) #9
pval...(no longer on Chromium)
Please take another look. https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp File chrome/android/chrome_apk.gyp (right): https://codereview.chromium.org/1282603005/diff/1/chrome/android/chrome_apk.gyp#newcode253 chrome/android/chrome_apk.gyp:253: '../../base/base.gyp:base_java_test_support', On 2015/08/12 23:25:58, pvalenzuela ...
5 years, 4 months ago (2015-08-14 21:51:11 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282603005/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282603005/40001
5 years, 4 months ago (2015-08-14 21:51:17 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/85242) ios_dbg_simulator_ninja on ...
5 years, 4 months ago (2015-08-14 21:53:32 UTC) #14
newt (away)
lgtm. Thank you! https://codereview.chromium.org/1282603005/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java File chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java (left): https://codereview.chromium.org/1282603005/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java#oldcode45 chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/SyncTestBase.java:45: assertTrue("Clearing app data failed.", clearAppData()); On ...
5 years, 4 months ago (2015-08-14 22:09:23 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282603005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282603005/60001
5 years, 4 months ago (2015-08-17 18:29:59 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99130)
5 years, 4 months ago (2015-08-17 19:55:11 UTC) #19
pval...(no longer on Chromium)
newt@, PTAL? I've fixed two problematic tests (see patch sets 5 and 6). jbudorick@, adding ...
5 years, 4 months ago (2015-08-18 23:33:07 UTC) #21
jbudorick
build/ lgtm
5 years, 4 months ago (2015-08-19 00:06:21 UTC) #22
newt (away)
lgtm
5 years, 4 months ago (2015-08-19 00:37:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282603005/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282603005/120001
5 years, 4 months ago (2015-08-19 00:51:12 UTC) #25
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 4 months ago (2015-08-19 02:09:06 UTC) #26
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/62ca3f0326203cca221bba6f0ee038ff292ecc66 Cr-Commit-Position: refs/heads/master@{#344128}
5 years, 4 months ago (2015-08-19 02:10:02 UTC) #27
tkent
A revert of this CL (patchset #7 id:120001) has been created in https://codereview.chromium.org/1285373007/ by tkent@chromium.org. ...
5 years, 4 months ago (2015-08-19 03:17:30 UTC) #28
newt (away)
5 years, 4 months ago (2015-08-25 18:03:57 UTC) #29
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698