Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: Source/devtools/front_end/sdk/NetworkManager.js

Issue 1282593003: DevTools: rely on response's "Content-Type" header to refine resource type (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/Source/devtools/front_end/sdk/NetworkManager.js b/Source/devtools/front_end/sdk/NetworkManager.js
index 96f65d817ea90cb785602cbfc224d3fcde8da50a..0f7d67f8be0b79d8dc0a0547b3be03a3de775179 100644
--- a/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/Source/devtools/front_end/sdk/NetworkManager.js
@@ -344,9 +344,13 @@ WebInspector.NetworkDispatcher.prototype = {
}
networkRequest.responseReceivedTime = time;
- networkRequest.setResourceType(WebInspector.resourceTypes[resourceType]);
this._updateNetworkRequestWithResponse(networkRequest, response);
+ var contentType = networkRequest.responseHeaderValue("Content-Type");
+ if (contentType && contentType.indexOf("javascript") !== -1)
+ networkRequest.setResourceType(WebInspector.resourceTypes.Script);
pfeldman 2015/08/07 23:32:46 How can resource type be wrong though?
pfeldman 2015/08/11 04:05:14 You should only do this in case the resource type
+ else
+ networkRequest.setResourceType(WebInspector.resourceTypes[resourceType]);
this._updateNetworkRequest(networkRequest);
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698