DevTools: rely on response's "Content-Type" header to refine resource type

Source/devtools/front_end/sdk/NetworkManager.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 326 matching lines @@
             eventData.url = response.url;
             eventData.frameId = frameId;
             eventData.loaderId = loaderId;
             eventData.resourceType = resourceType;
             eventData.mimeType = response.mimeType;
             this._manager.dispatchEventToListeners(WebInspector.NetworkManager.EventTypes.RequestUpdateDropped, eventData);
             return;
         }
 
         networkRequest.responseReceivedTime = time;
-        networkRequest.setResourceType(WebInspector.resourceTypes[resourceType]);
 
         this._updateNetworkRequestWithResponse(networkRequest, response);
+        var contentType = networkRequest.responseHeaderValue("Content-Type");
+        if (contentType && contentType.indexOf("javascript") !== -1)
+            networkRequest.setResourceType(WebInspector.resourceTypes.Script);

[pfeldman, 2015/08/07 23:32:46]

How can resource type be wrong though?

[pfeldman, 2015/08/11 04:05:14]

You should only do this in case the resource type is document and it probably
belongs to the backend.

+        else
+            networkRequest.setResourceType(WebInspector.resourceTypes[resourceType]);
 
         this._updateNetworkRequest(networkRequest);
     },
 
     /**
      * @override
      * @param {!NetworkAgent.RequestId} requestId
      * @param {!NetworkAgent.Timestamp} time
      * @param {number} dataLength
      * @param {number} encodedDataLength
@@ skipping 318 matching lines @@
         this._userAgent = userAgent;
         for (var target of WebInspector.targetManager.targets())
             target.networkAgent().setUserAgentOverride(this._userAgent);
     }
 }
 
 /**
  * @type {!WebInspector.MultitargetNetworkManager}
  */
 WebInspector.multitargetNetworkManager;