Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1282593003:
DevTools: rely on response's "Content-Type" header to refine resource type (Closed)
|
Created:
5 years, 4 months ago by lushnikov Modified:
5 years, 4 months ago Reviewers:
pfeldman CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org Base URL:
https://chromium.googlesource.com/chromium/blink.git@master Target Ref:
refs/heads/master Project:
blink Visibility:
Public. |
DescriptionDevTools: rely on response's "Content-Type" header to refine resource type
BUG=515518
R=pfeldman@chromium.org, pfeldman
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200681
Patch Set 1 #
Total comments: 2
Patch Set 2 : new version #Patch Set 3 : fix #Patch Set 4 : rebaseline #Messages
Total messages: 21 (8 generated)
зефд
https://codereview.chromium.org/1282593003/diff/1/Source/devtools/front_end/s... File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/1282593003/diff/1/Source/devtools/front_end/s... Source/devtools/front_end/sdk/NetworkManager.js:351: networkRequest.setResourceType(WebInspector.resourceTypes.Script); How can resource type be wrong though?
https://codereview.chromium.org/1282593003/diff/1/Source/devtools/front_end/s... File Source/devtools/front_end/sdk/NetworkManager.js (right): https://codereview.chromium.org/1282593003/diff/1/Source/devtools/front_end/s... Source/devtools/front_end/sdk/NetworkManager.js:351: networkRequest.setResourceType(WebInspector.resourceTypes.Script); On 2015/08/07 23:32:46, pfeldman wrote: > How can resource type be wrong though? You should only do this in case the resource type is document and it probably belongs to the backend.
ptal
The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282593003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282593003/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282593003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282593003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by lushnikov@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pfeldman@chromium.org Link to the patchset: https://codereview.chromium.org/1282593003/#ps60001 (title: "rebaseline")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282593003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282593003/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by lushnikov@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282593003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282593003/60001
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 200681 (presubmit successful). |
