Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1282593002: Add ChromeVox panel and implement caption display functionality. (Closed)

Created:
5 years, 4 months ago by dmazzoni
Modified:
5 years, 4 months ago
Reviewers:
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add ChromeVox panel and implement caption display functionality. This patch creates a new HTML background page in the extension that's formatted with a menu button, a caption area for speech and braille, a settings button, and a close button. Currently only the caption part functions - it uses cross-window messages to send either the current speech from TTS, or the current braille text and cells if braille captions are enabled. This patch does not contain the code to show the caption panel on the screen, that will follow. You can test it in the meantime by manually opening up the URL. BUG=420795

Patch Set 1 #

Patch Set 2 : Revert changes to accessibility_manager in this change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+392 lines, -17 lines) Patch
M chrome/browser/resources/chromeos/chromevox/BUILD.gn View 4 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/braille/braille_display_manager.js View 1 chunk +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gni View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox.gyp View 5 chunks +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox/background/braille_captions_background.js View 2 chunks +17 lines, -7 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/chromevox/close-white.png View Binary file 0 comments Download
A chrome/browser/resources/chromeos/chromevox/chromevox/close-white-hover.png View Binary file 0 comments Download
A chrome/browser/resources/chromeos/chromevox/chromevox/options.png View Binary file 0 comments Download
A chrome/browser/resources/chromeos/chromevox/chromevox/triangle.png View Binary file 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_assets.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/chromevox_vars.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.html View 1 chunk +128 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/panel.js View 1 chunk +121 lines, -0 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_command.js View 1 chunk +47 lines, -0 lines 0 comments Download
A + chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_loader.js View 1 chunk +5 lines, -6 lines 0 comments Download
A chrome/browser/resources/chromeos/chromevox/cvox2/background/test.html View 1 chunk +13 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js View 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/tools/check_chromevox.py View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Powered by Google App Engine
This is Rietveld 408576698