Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 1282563003: [Android] Convert RestartAdbd to DeviceUtils again. (Closed)

Created:
5 years, 4 months ago by rnephew (Reviews Here)
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Convert RestartAdbd to DeviceUtils again. BUG=267773 Committed: https://crrev.com/8960d19f34b81a1f422422d03dc6b6361fd4a3df Cr-Commit-Position: refs/heads/master@{#342621}

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : add device test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -3 lines) Patch
M build/android/pylib/device/device_utils.py View 1 2 chunks +18 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils_device_test.py View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +14 lines, -1 line 0 comments Download
M build/android/pylib/perf/test_runner.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/utils/test_environment.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
rnephew (Reviews Here)
I currently have this running locally on 6 devices ( 3 N7, 1 N4, 1 ...
5 years, 4 months ago (2015-08-07 21:54:09 UTC) #2
jbudorick
https://codereview.chromium.org/1282563003/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/1282563003/diff/1/build/android/pylib/device/device_utils.py#newcode1819 build/android/pylib/device/device_utils.py:1819: def RestartAdbd(self, timeout=None, retries=None): This should have a device_test.
5 years, 4 months ago (2015-08-07 22:02:43 UTC) #3
rnephew (Reviews Here)
All 500 iterations ran without a problem. https://codereview.chromium.org/1282563003/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/1282563003/diff/1/build/android/pylib/device/device_utils.py#newcode1819 build/android/pylib/device/device_utils.py:1819: def RestartAdbd(self, ...
5 years, 4 months ago (2015-08-07 22:42:11 UTC) #4
perezju
changes lgtm
5 years, 4 months ago (2015-08-10 07:25:47 UTC) #5
jbudorick
once more unto the breach lgtm
5 years, 4 months ago (2015-08-10 12:59:51 UTC) #6
jbudorick
On 2015/08/10 at 12:59:51, jbudorick wrote: > once more unto the breach > > lgtm ...
5 years, 4 months ago (2015-08-10 13:04:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282563003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282563003/40001
5 years, 4 months ago (2015-08-10 13:12:02 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-10 15:28:13 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-10 15:28:45 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8960d19f34b81a1f422422d03dc6b6361fd4a3df
Cr-Commit-Position: refs/heads/master@{#342621}

Powered by Google App Engine
This is Rietveld 408576698