Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1282543002: Fix NSMenuItemAdditionsTest.TestMOnDifferentLayouts on 10.11 (Closed)

Created:
5 years, 4 months ago by Bons
Modified:
5 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix NSMenuItemAdditionsTest.TestMOnDifferentLayouts on 10.11 The keyboard layout ABC - AZERTY was added in 10.11, which maps 'm' to the same keycode as the Belgian, Italian, and French layouts. Add this case. BUG=none TEST=NSMenuItemAdditionsTest.TestMOnDifferentLayouts Committed: https://crrev.com/f9f39df91828ff9acdfc2b6921b2397011c3d19e Cr-Commit-Position: refs/heads/master@{#342375}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/ui/cocoa/nsmenuitem_additions_unittest.mm View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Bons
5 years, 4 months ago (2015-08-07 17:17:04 UTC) #2
Robert Sesek
lgtm
5 years, 4 months ago (2015-08-07 17:18:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282543002/1
5 years, 4 months ago (2015-08-07 17:19:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-07 17:39:57 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-07 17:40:40 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9f39df91828ff9acdfc2b6921b2397011c3d19e
Cr-Commit-Position: refs/heads/master@{#342375}

Powered by Google App Engine
This is Rietveld 408576698