test/dart2js/supports_valid_options_test.dart - Issue 1282533003: Don't implicitly run "pub get".

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/dart2js/supports_valid_options_test.dart

Issue 1282533003: Don't implicitly run "pub get". (Closed) Base URL: git@github.com:dart-lang/pub.git@master

Patch Set: Code review changes Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: test/dart2js/supports_valid_options_test.dart

diff --git a/test/dart2js/supports_valid_options_test.dart b/test/dart2js/supports_valid_options_test.dart

index ec02f4dd19cff2d88b1dc7e5bb7ed70d5968561c..7ced80766b21f83a5e333ae766678f71660ad4a8 100644

--- a/test/dart2js/supports_valid_options_test.dart

+++ b/test/dart2js/supports_valid_options_test.dart

@@ -34,8 +34,10 @@ main() {

])

]).create();

+ pubGet();

// None of these options should be rejected, either by pub or by dart2js.

- pubServe(shouldGetFirst: true);

+ pubServe();

requestShouldSucceed("main.dart.js", isNot(isEmpty));

endPubServe();

});