Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1282533002: Run browser_tests on Linux GN. (Closed)

Created:
5 years, 4 months ago by jam
Modified:
5 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Run browser_tests on Linux GN. BUG=463180 NOTRY=true Committed: https://crrev.com/66f8afe20e1e060b0c5d621ef89acd33df9891f8 Cr-Commit-Position: refs/heads/master@{#342552}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : nit and fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M chrome/test/BUILD.gn View 1 2 3 4 2 chunks +48 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 2 chunks +7 lines, -1 line 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (6 generated)
jam
5 years, 4 months ago (2015-08-07 23:03:21 UTC) #2
Dirk Pranke
lgtm w/ one nit. https://codereview.chromium.org/1282533002/diff/80001/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/1282533002/diff/80001/testing/buildbot/chromium.linux.json#newcode239 testing/buildbot/chromium.linux.json:239: "browser_tests", You can also delete ...
5 years, 4 months ago (2015-08-07 23:49:43 UTC) #4
jam
https://codereview.chromium.org/1282533002/diff/80001/testing/buildbot/chromium.linux.json File testing/buildbot/chromium.linux.json (right): https://codereview.chromium.org/1282533002/diff/80001/testing/buildbot/chromium.linux.json#newcode239 testing/buildbot/chromium.linux.json:239: "browser_tests", On 2015/08/07 23:49:42, Dirk Pranke wrote: > You ...
5 years, 4 months ago (2015-08-08 01:50:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282533002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282533002/100001
5 years, 4 months ago (2015-08-09 04:31:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1282533002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1282533002/100001
5 years, 4 months ago (2015-08-09 04:36:17 UTC) #11
jam
setting NOTRY=true since it was already tried
5 years, 4 months ago (2015-08-09 04:36:22 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 4 months ago (2015-08-09 04:41:47 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-09 04:42:29 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/66f8afe20e1e060b0c5d621ef89acd33df9891f8
Cr-Commit-Position: refs/heads/master@{#342552}

Powered by Google App Engine
This is Rietveld 408576698