Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 12825014: Cleanup a few probably-incorrect OS_<random> uses. (Closed)

Created:
7 years, 9 months ago by Scott Hess - ex-Googler
Modified:
7 years, 8 months ago
Reviewers:
zel, robertphillips
CC:
chromium-reviews, Aaron Boodman, feature-media-reviews_chromium.org, sail+watch_chromium.org, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Cleanup a few probably-incorrect OS_<random> uses. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194474

Patch Set 1 #

Patch Set 2 : Retract gpu change. #

Patch Set 3 : retract the un-reviewed changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/autotest_private/autotest_private_api.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Scott Hess - ex-Googler
zelidrag: autotest_private_api.cc also native_process_launcher_posix.cc miket: pedantic extension_crash_recovery_browsertest.cc comment change dalecurtis: gpu_video_decoder.cc (possibly already landed) robertphillips: ...
7 years, 9 months ago (2013-03-20 00:36:03 UTC) #1
DaleCurtis
scherkus has https://codereview.chromium.org/12879010/ out for the gpu decode one. fischman wants some testing first.
7 years, 9 months ago (2013-03-20 00:41:53 UTC) #2
zel
lgtm
7 years, 9 months ago (2013-03-20 00:43:03 UTC) #3
Scott Hess - ex-Googler
On 2013/03/20 00:41:53, DaleCurtis wrote: > scherkus has https://codereview.chromium.org/12879010/ out for the gpu decode > ...
7 years, 9 months ago (2013-03-20 00:50:51 UTC) #4
Scott Hess - ex-Googler
Looks like nico landed https://codereview.chromium.org/12566038/ to handle the two osx ones. So now it's just ...
7 years, 9 months ago (2013-03-20 04:09:19 UTC) #5
miket_OOO
My review is now superfluous but LGTM.
7 years, 9 months ago (2013-03-20 15:38:05 UTC) #6
Scott Hess - ex-Googler
On 2013/03/20 00:43:03, zel wrote: > lgtm Since the skia change hasn't seen review, I'll ...
7 years, 8 months ago (2013-04-16 22:57:13 UTC) #7
Scott Hess - ex-Googler
Committed patchset #3 manually as r194474 (presubmit successful).
7 years, 8 months ago (2013-04-16 22:59:35 UTC) #8
robertphillips
lgtm. Specifically w.r.t. the changes in skia/ext/platform_device.h. Sorry about the delay (I didn't realize you ...
7 years, 8 months ago (2013-04-16 23:09:45 UTC) #9
Scott Hess - ex-Googler
7 years, 8 months ago (2013-04-17 00:20:56 UTC) #10
Message was sent while issue was closed.
In case you're here because of broken builds, I just realized I entirely forgot
about trybots runs when manually landing.  Apologies.  Note that there were
(mostly) clean trybots on the first patch, and later patches removed files from
the CL, so the earlier trybots runs did include this changed line.

Powered by Google App Engine
This is Rietveld 408576698