Issue 12825003: Remove bottom-up CPU profile

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12825003: Remove bottom-up CPU profile (Closed)

Created:
7 years, 9 months ago by yurys

Modified:
7 years, 9 months ago

Reviewers:
Jakob Kummerow, loislo

CC:
chromium-reviews

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove bottom-up CPU profile Bottom-up view of CPU profile can be restored based on top-down profile data. So there is no need to spend resources on creating both of them inside V8. BUG=None Committed: https://code.google.com/p/v8/source/detail?r=13958

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Updated CpuProfile class comment #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -50 lines)			Patch
M	include/v8-profiler.h	View	1 2 3	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/api.cc	View	1 3	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/cpu-profiler.cc	View	3	1 chunk	+0 lines, -1 line	0 comments	Download
M	src/profile-generator.h	View	3	2 chunks	+0 lines, -2 lines	0 comments	Download
M	src/profile-generator.cc	View	3	3 chunks	+0 lines, -8 lines	0 comments	Download
M	test/cctest/test-cpu-profiler.cc	View	3	1 chunk	+0 lines, -25 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

yurys

WebKit code that used to use the API is removed in https://bugs.webkit.org/show_bug.cgi?id=112351

7 years, 9 months ago (2013-03-14 15:58:47 UTC) #1

Jakob Kummerow

LGTM from a V8 point of view; however I don't know if there are any ...

7 years, 9 months ago (2013-03-14 16:31:20 UTC) #2

yurys

7 years, 9 months ago (2013-03-15 08:03:03 UTC) #3

On 2013/03/14 16:31:20, Jakob wrote:
> LGTM from a V8 point of view; however I don't know if there are any other
> external consumers of this API.

I don't know of other consumers either. Node.js? My first intent was to mark the
API as V8_DEPRECATED and start returning 0 from the method. But that would just
hide the problem and postpone it from compile time to the profiling time.

Expand Messages | Collapse Messages