Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 1282483002: Disable InstantExtendedTest.OmniboxMarginSetForSearchURLs on Linux Asan due to flaky crashes at shu… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_extended_interactive_uitest.cc
diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
index 3490fc2da1d63789f8b47dadb7ced0f8356ca73a..7ecfe16929d09323b687f7e64f30c163550e6b73 100644
--- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
+++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
@@ -430,7 +430,15 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
ASSERT_THAT(active_tab->GetURL().spec(), HasSubstr("q=puppies"));
}
-IN_PROC_BROWSER_TEST_F(InstantExtendedTest, OmniboxMarginSetForSearchURLs) {
+#if defined(OS_LINUX) && defined(ADDRESS_SANITIZER)
+// Flaky crashes at shutdown on Linux Asan; http://crbug.com/517886.
+#define MAYBE_OmniboxMarginSetForSearchURLs \
+ DISABLED_OmniboxMarginSetForSearchURLs
+#else
+#define MAYBE_OmniboxMarginSetForSearchURLs OmniboxMarginSetForSearchURLs
+#endif
+IN_PROC_BROWSER_TEST_F(InstantExtendedTest,
+ MAYBE_OmniboxMarginSetForSearchURLs) {
ASSERT_NO_FATAL_FAILURE(SetupInstant(browser()));
FocusOmnibox();
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698