Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Unified Diff: runtime/vm/isolate.cc

Issue 1282423003: Enable iterating over roots from helper threads by moving stack walking. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/isolate.cc
diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc
index fcbf9c483775f350396dc4110804f6367429e2d0..e0f8752c1d1ec4c1c163e4bcfd46bf6fec605b11 100644
--- a/runtime/vm/isolate.cc
+++ b/runtime/vm/isolate.cc
@@ -1598,14 +1598,6 @@ void Isolate::VisitObjectPointers(ObjectPointerVisitor* visitor,
// Visit objects in isolate specific handles area.
reusable_handles_.VisitObjectPointers(visitor);
- // Iterate over all the stack frames and visit objects on the stack.
- StackFrameIterator frames_iterator(validate_frames);
Ivan Posva 2015/08/11 17:41:31 Can you please explain how we are validating frame
- StackFrame* frame = frames_iterator.NextFrame();
- while (frame != NULL) {
- frame->VisitObjectPointers(visitor);
- frame = frames_iterator.NextFrame();
- }
-
// Visit the dart api state for all local and persistent handles.
if (api_state() != NULL) {
api_state()->VisitObjectPointers(visitor, visit_prologue_weak_handles);
« no previous file with comments | « runtime/vm/heap.cc ('k') | runtime/vm/pages.h » ('j') | runtime/vm/thread_registry.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698